Skip to content

Use absolute paths for dotnet launched DLLs#89

Open
FelixDamrau wants to merge 1 commit into
zed-extensions:mainfrom
FelixDamrau:fix-cs-langu-srv
Open

Use absolute paths for dotnet launched DLLs#89
FelixDamrau wants to merge 1 commit into
zed-extensions:mainfrom
FelixDamrau:fix-cs-langu-srv

Conversation

@FelixDamrau

Copy link
Copy Markdown

resolves #88

Zed spawns dotnet with its working directory set to the worktree root.
We must use absolute paths to reference the cs-language server, so the extension installed one can be found.

@cla-bot

cla-bot Bot commented Jun 6, 2026

Copy link
Copy Markdown

We require contributors to sign our Contributor License Agreement, and we don't have @FelixDamrau on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

@FelixDamrau

Copy link
Copy Markdown
Author

info

Only affects systems that do not have cs-language server installed as a global tool.
Guess that's why it wasn't found before/during development.
@rbstp -> Can you confirm that?

Same problem is in roslyn.rs, but this usually doesn't start DLLs

@FelixDamrau

Copy link
Copy Markdown
Author

@cla-bot check

@cla-bot cla-bot Bot added the cla-signed label Jun 6, 2026
@cla-bot

cla-bot Bot commented Jun 6, 2026

Copy link
Copy Markdown

The cla-bot has been summoned, and re-checked this pull request!

@rbstp

rbstp commented Jun 6, 2026

Copy link
Copy Markdown
Contributor

@FelixDamrau Turns out I've got csharp-ls installed as a global dotnet tool, so worktree.which("csharp-ls") finds it and short-circuits before we ever reach the dotnet exec path. That's why this never showed up while I was working on it.

I went back and reproduced the failure using the relative DLL path from a cwd outside the extension, and confirmed that the absolute path resolves it fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot start csharp-ls

2 participants